Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #485: remove score parameter from cs_order #487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rstuart-indue
Copy link

@rstuart-indue rstuart-indue commented May 31, 2020

I didn't spot an open PR on this, but there is open issue #485

It seems that the release of pacemaker 2.0.3 (in RHEL8) removes the option of supplying the superfluous score parameter.

Here is the documentation for pacemaker 2.0 which makes no mention of a score property:
https://clusterlabs.org/pacemaker/doc/en-US/Pacemaker/2.0/html/Pacemaker_Explained/s-resource-ordering.html

Pull Request (PR) description

Removes the score parameter from cs_order type as it is no longer valid and causes errors.

This Pull Request (PR) fixes the following issues

Fixes #485

@vox-pupuli-tasks
Copy link

Dear @rstuart-indue, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@igalic igalic mentioned this pull request Aug 30, 2020
@bastelfreak
Copy link
Member

I tried to rebase this on my own and failed :(

@shaneshort
Copy link

Is there anything still outstanding on this PR? is there a reason it hasn't been merged?

@bastelfreak
Copy link
Member

@shaneshort it has some merge conflicts and the tests don't pass, we cannot merge it this way. I don't know how to fix them :(

@vox-pupuli-tasks
Copy link

Dear @rstuart-indue, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@zpeschke
Copy link

score is still a valid optional parameter according to the order constraint schema: https://github.com/ClusterLabs/pacemaker/blob/master/xml/constraints-3.5.rng#L155-L160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cs_order fails with pcs provider because of score parameter
4 participants